Re: [PATCH] New x86_64 time code for 2.5.70

[Vojtech Pavlik]

On Thu, Jun 12, 2003 at 12:32:01AM +0300, Mika Penttilä wrote:
> /*
> + * Read the period, compute tick and quotient.
> + */
> +
> +	id = hpet_readl(HPET_ID);
> +
> +	if (!(id & HPET_ID_VENDOR) || !(id & HPET_ID_NUMBER) ||
> +	    !(id & HPET_ID_LEGSUP))
> +		return -1;
> +
> +	hpet_period = hpet_readl(HPET_PERIOD);
> +	if (hpet_period < 100000 || hpet_period > 100000000)
> +		return -1;
> +
> 
> 
> Line below seems to be wrong, given hpet period is in fsecs.
> 
> 
> +	hpet_tick = (tick_nsec + hpet_period / 2) / hpet_period;

Yes, it should be:

hpet_tick = (1000000000L * (USECS_PER_SEC/HZ) + hpet_period / 2) / hpet_period;

> 
> 
> 
> 
> 
> --Mika
> 
> 
> 
> 
> 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR