Re: problem when compile 2.5.70-mm8

[Thomas Schlichter]

--Boundary-03=_I725+fmLDJkIesw
Content-Type: multipart/mixed;
  boundary="Boundary-01=_I725+cyxyXI+/ci"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_I725+cyxyXI+/ci
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

jds wrote:
> Hi:
>
>    I try the compile kernel 2.5.70-mm8 and recive this messages:
  ~~ snip ~~
>   CC      arch/i386/kernel/setup.o
> arch/i386/kernel/setup.c: In function `setup_early_printk':
> arch/i386/kernel/setup.c:919: invalid lvalue in unary `&'
> make[1]: *** [arch/i386/kernel/setup.o] Error 1
> make: *** [arch/i386/kernel] Error 2
>
>   Help me please;
>
>   Regards.

As posted before the attached patch helps.

If you do not want to use the EARLY_PRINTK feature at all but are too lazy =
to=20
turn it off in the Kernel debug menu explicitly (as I am, too ;-) you may=20
also use the second attached patch wich corrects dependencies in Kconf.

Best regards
   Thomas Schlichter

--Boundary-01=_I725+cyxyXI+/ci
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="early_printk_fix.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline; filename="early_printk_fix.diff"

=2D-- linux-2.5.70-mm8/arch/i386/kernel/setup.c.orig	Wed Jun 11 11:10:35 20=
03
+++ linux-2.5.70-mm8/arch/i386/kernel/setup.c	Wed Jun 11 11:11:36 2003
@@ -910,6 +910,7 @@
 extern int __init serial8250_console_init(void);
 void setup_early_printk(void)
 {
+#ifdef CONFIG_SMP
 	/*=20
 	 * printk currently checks cpu_online_map to make sure that
 	 * we don't try to printk from a CPU which hasn't had resources
@@ -917,6 +918,7 @@
 	 * enable here don't require per-cpu resources.
 	 */
 	set_bit(smp_processor_id(), &cpu_online_map);
+#endif
 #ifdef CONFIG_DEBUG_EP_SERIAL
 	console_setup(CONFIG_DEBUG_SERIAL_OPTIONS);
 	serial8250_console_init();

--Boundary-01=_I725+cyxyXI+/ci
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="early_printk_Kconf.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline; filename="early_printk_Kconf.diff"

=2D-- linux-2.5.70-mm8/arch/i386/Kconfig.orig	Wed Jun 11 11:23:17 2003
+++ linux-2.5.70-mm8/arch/i386/Kconfig	Wed Jun 11 11:25:25 2003
@@ -1795,7 +1795,7 @@
=20
 config DEBUG_EARLY_PRINTK
 	bool
=2D	depends on !DEBUG_EARLY_PRINTK_OFF
+	depends on DEBUG_EP_SERIAL || DEBUG_EP_VGA
 	default y
=20
 config DEBUG_SERIAL_OPTIONS

--Boundary-01=_I725+cyxyXI+/ci--

--Boundary-03=_I725+fmLDJkIesw
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+527IYAiN+WRIZzQRArjBAJ9UNRVIB2tmE30Xhqqmt8mm4t+hCACfdtH5
FavNL/jabkQOTn1Y2PVUFYM=
=9B2s
-----END PGP SIGNATURE-----

--Boundary-03=_I725+fmLDJkIesw--