Re: [PATCH] nfs_unlink() race (was: nfs_refresh_inode: inode number

Linus Torvalds (torvalds@transmeta.com)
Wed, 11 Jun 2003 08:08:56 -0700 (PDT)


On 11 Jun 2003, Alan Cox wrote:
>
> For vfat at least its all broken.

Looks like a different issue, not dentry aliasing per se.

> cd foo
> mv ../file .
> more file
>
> ESTALE.

Yes, VFAT ends up encoding the parent directory in the FH, so renaming
will invalidate the old file handle, and if you cache inodes (and thus
filehandles) over a directory move, badness happens.

Arguably it's a NFS client problem - the path revalidate at open time
should have caught the ESTALE and forced a new inode lookup. But I think
you can also argue that VFAT over NFS is just non-unixy enough that it
just isn't really "supported".

I think it's more of a "you can NFS-export strange filesystems for some
limited file sharing, but if things break, you get to keep both pieces".

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/