RE: select for UNIX sockets?

[David Schwartz]

> "David Schwartz" <[e-mail]> writes:

> > For the last time, there is no socket queue. You wouldn't want there
> > to be
> > one.

> Sure. No queue. Of course.

	Yep.

> And these are only misleading names - net/unix/af_unix.c:
> static int unix_dgram_sendmsg(struct kiocb *kiocb, struct socket *sock,
>                               struct msghdr *msg, int len)
> {
> ...
>
>        if (unix_peer(other) != sk &&
>             skb_queue_len(&other->receive_queue) >
> other->max_ack_backlog) {

	That looks like a *receive* queue to me. We were talking about selecting
for writes, weren't we.

> and then
>
>         skb_queue_tail(&other->receive_queue, skb);
>         unix_state_runlock(other);
>         other->data_ready(other, len);
>         sock_put(other);
>
> Right?

	Looks like another receive queue to me. There is no send queue and you
wouldn't want there to be one.

> > Consider a UDP application that is sending packets to two
> > destinations, one
> > over a 56Kbps serial link running PPP and one over gigabit Ethernet. If
> > there were a socket send queue, the packets going over the 56Kbps serial
> > link would block the packets going over the gigabit Ethernet.

> First, PPP and Ethernet use IP/UDP and not local UNIX sockets.
> Second, I hope you don't want to tell me PPP and Ethernet have no
> device queues, do you? Sure there are "virtual" devices with no queue,
> but that's another story.
> Have you checked what the above scenario would do? I guess the PPP would
> really limit the rate if you used only one socket.

	They have device queues, they have no socket send queues.

> Having no per-sender socket queue for UDP/IP is totally irrelevant here.

	It is relevent. Because when you select for write, you're trying to find
out whether there's space to write to the socket. That would require there
to be something for there to be space in or not to be space in. Whatever you
want to call that (I call it a 'socket send queue', but it doesn't matter)
that queue doesn't exist for UDP and you wouldn't want it to exist.

	With UDP, or any connectionless protocol, the application is ultimately
responsible for transmit pacing. You could argue that it would be nice if
the kernel helped out more than it currently does, but it has no obligation
to do so.

	DS