Re: [PATCH] IDE Power Management, try 2

Bartlomiej Zolnierkiewicz (B.Zolnierkiewicz@elka.pw.edu.pl)
Tue, 10 Jun 2003 18:36:41 +0200 (MET DST)


On 10 Jun 2003, Benjamin Herrenschmidt wrote:

> On Tue, 2003-06-10 at 18:15, Jens Axboe wrote:
> > On Thu, Jun 05 2003, Bartlomiej Zolnierkiewicz wrote:
> > > Jens, I think generic version of ide_do_drive_cmd() would be useful for
> > > other block devices, what do you think?
> >
> > Something ala this? Completely untested, and I only did scsi_ioctl.c and
> > ide-io.c. iirc, scsi uses somthing similar that could be adapted too.
>
> Hrm... you didn't keep some functionalities I added with the PM
> patch here... like marking of preempt requests so I can fetch them
> even when drive is blocked, and ide_head_wait...
>
> Ben

I've looked for users of ide_preempt in drivers/ide/ and I think
that REQ_PREEMPT can later die if we fix drivers to correctly mark
sense requests with REQ_SENSE...

--
Bartlomiej

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/