Re: [PATCH] loop 2/9 absorb bio_copy

[Jens Axboe]

On Tue, Jun 10 2003, Hugh Dickins wrote:
> bio_copy is used only by the loop driver, which already has to walk the
> bio segments itself: so it makes sense to change it from bio.c export
> to loop.c static, as prelude to working upon it there.
> 
> bio_copy itself is unchanged by this patch, with one exception.  On oom
> failure it must use bio_put, instead of mempool_free to static bio_pool:
> which it should have been doing all along - it was leaking the veclist.

I don't think this is is a particularly good idea, it's pretty core bio
functionality that should be left alone in bio.c imho.

Is there a real reason you want to do this apart from 'loop is the only
(current) user'?

-- 
Jens Axboe