Re: [PATCH][ATM] use rtnl_{lock,unlock} during device operations (take 2)

Duncan Sands (baldrick@wanadoo.fr)
Mon, 9 Jun 2003 15:37:13 +0200


> btw, you might get async device 'releases' more often than
> you would like. some atm devices are usb and could be
> unplugged during operation (yes, that's really bad but it
> would be wise to be prepared for this.) i actually have
> a cardbus atm interface. i might eject it accidentally.

Right. In the speedtouch (USB ATM DSL modem) driver, when the
device is unplugged I would have liked to be able to say to the
ATM layer: I've gone, don't call me any more. But since there
is no way to do this, instead I do:

- refuse to open any more vccs; fail all attempts to send packets
- call shutdown_atm_dev. This means that when the last vcc is
closed, atm_dev_close will be called in my driver.
- really shutdown in atm_dev_close

In practice that means that the vcc remains open until pppd realises
that the connection has gone down (no more echo requests getting
through, for example). Maybe I should push a NULL skb down into
each vcc to get it to close?

Another thing: if the modem is plugged in again, and pppd relaunched,
it would be nice if connections that were open when the modem was
unplugged automagically recovered. Is that possible?

Ciao,

Duncan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/