Re: [PATCH] Move BUG/BUG_ON/WARN_ON to asm headers

Linus Torvalds (torvalds@transmeta.com)
Sun, 8 Jun 2003 11:12:39 -0700 (PDT)


On Sat, 7 Jun 2003, Bartlomiej Zolnierkiewicz wrote:
>
> What about adding asm-generic/bug.h ?

I personally dislike infrastructure that isn't a big win.

Shared files ("generic" stuff) end up being useful mainly if they are
_really_ generic, and they do something that takes more effort to do than
it takes to learn about the generic interface.

For trivial stuff that isn't even really generic (ie several architectures
are likely to want to tinker with their implementation), trying to have a
generic version is just not worth it, imho.

In general, I tend to like independent copies with small (but locally
obvious) variations over one generic one with non-locally-obvious
semantics - things like "mostly people use this version, except if XXXX is
defined, in which case they use their own" are just a total nightmare in
my opinion.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/