Re: [patch] 2.5.70-mm5: fix ieee1394_core.c compile if !CONFIG_PROC_FS

[Sam Ravnborg]

On Sat, Jun 07, 2003 at 01:06:25PM -0700, Andrew Morton wrote:
> Adrian Bunk <[e-mail]> wrote:
> >
> > I got the following compile error with !CONFIG_PROC_FS:
> > 
> > The following patch fixes it:
> > --- linux-2.5.70-mm5/drivers/ieee1394/ieee1394_core.c.old	2003-06-07 16:42:35.000000000 +0200
> > +++ linux-2.5.70-mm5/drivers/ieee1394/ieee1394_core.c	2003-06-07 16:42:47.000000000 +0200
> > @@ -1228,7 +1228,9 @@
> >  
> >  	unregister_chrdev(IEEE1394_MAJOR, "ieee1394");
> >  	devfs_remove("ieee1394");
> > +#ifdef CONFIG_PROC_FS
> >  	remove_proc_entry("ieee1394", proc_bus);
> > +#endif
> >  }
> >  
> 
> proc_fs.h has:
> 
> static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};
> 
> for the !CONFIG_PROC_FS case, so that _should_ have prevented this problem.
>  What went wrong?
proc_bus is only defined when CONFIG_PROC

	Sam