Re: [PATCH] hugetlbfs: fix error reporting in case of invalid mount

[René Scharfe]

On Sat, 7 Jun 2003 09:35:21 -0700 William Lee Irwin III <[e-mail]> wrote:
> Let's nuke it entirely. All other fs's barf without printk()'ing at all
> and kick -EINVAL back to the caller.

Mmmkay, even better. Patch below.

René

diff -u ./fs/hugetlbfs/inode.c~ ./fs/hugetlbfs/inode.c
--- ./fs/hugetlbfs/inode.c~	2003-06-07 19:22:27.000000000 +0200
+++ ./fs/hugetlbfs/inode.c	2003-06-07 19:23:03.000000000 +0200
@@ -524,10 +524,9 @@
 	struct hugetlbfs_config config;
 
 	ret = hugetlbfs_parse_options(data, &config);
-	if (ret) {
-		printk("hugetlbfs: invalid mount options: %s.\n", data);
+	if (ret)
 		return ret;
-	}
+
 	sb->s_blocksize = PAGE_CACHE_SIZE;
 	sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
 	sb->s_magic = HUGETLBFS_MAGIC;