Re: [patch] fix vlsi_ir.c compile if !CONFIG_PROC_FS

[Adrian Bunk]

On Sat, Jun 07, 2003 at 06:22:39PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> Apply something like this:
> 
> --- linux-2.5.70-bk11/include/proc_fs.h	Fri Jun  6 18:43:49 2003
> +++ linux/include/proc_fs.h	Sat Jun  7 18:11:22 2003
> @@ -205,7 +205,7 @@
>  static inline struct proc_dir_entry *create_proc_entry(const char *name,
>  	mode_t mode, struct proc_dir_entry *parent) { return NULL; }
> 
> -static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};
> +#define remove_proc_entry(name, parent)	/* nothing */
>  static inline struct proc_dir_entry *proc_symlink(const char *name,
>  		struct proc_dir_entry *parent,char *dest) {return NULL;}
>  static inline struct proc_dir_entry *proc_mknod(const char *name,mode_t mode,
> 
> And you wil not have to readd #ifdef/#endif pair.
> 
> I've seen Sam's mail but this is generic solution to quiet compiler
> and will work for any remove_proc_entry() user.

Yup, for this specific error Sam's solution is the best one, but your 
patch e.g. solves the ieee1394_core.c compile error I reported, too.

> Thanks,
> --
> Bartlomiej

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed