Re: [Patch] 2.5.70-bk11 zlib cleanup #3 Z_NULL

[Jörn Engel]

On Fri, 6 June 2003 11:54:45 -0700, Linus Torvalds wrote:
> On Fri, 6 Jun 2003, Jörn Engel wrote:
> > 
> > How do you feel about "if (z->state->blocks != NULL)"?  Remove the
> > pointless !=NULL or keep it?
> 
> I don't mind it, but it doesn't buy much.
> 
> It's actually in some other cases where I think there is a readability 
> issue, ie in more complex conditionals I personally prefer the simpler 
> cersion, ie I much prefer something like
> 
> 	if (ptr && ptr->ops && ptr->ops->shutdown)
> 		ptr->ops->shutdown(ptr, xxxx);
> 
> over the pointless NULL-masturbation in something like
> 
> 	if (ptr != NULL && ptr->ops != NULL && ptr->ops->shutdown != NULL)
> 		ptr->ops->shutdown(ptr, xxxx)
> 
> which I just is much less readable than the simple version.

Good example.  The ones I found in the zlib are not that bad and I am
lazy, so I'll leave them for someone else.

Jörn

-- 
Courage is not the absence of fear, but rather the judgement that
something else is more important than fear.
-- Ambrose Redmoon