RE: [PATCH] megaraid driver fix for 2.5.70

[Mukker, Atul]

> > Coming back to main issue, declaring complete mailbox would 
> be superfluous
> > since driver uses 16 bytes at most. The following patch 
> should fix the panic
> > 
> >  	mbox = (mbox_t *)raw_mbox;
> >  
> > -	memset(mbox, 0, sizeof(*mbox));
> > +	memset(mbox, 0, 16);
> >  
> >  	memset((void *)adapter->mega_buffer, 0, MEGA_BUFFER_SIZE);
> >  
> 
> This, I think, is a bad idea.  It looks intrinsically wrong 
> to allocate
> storage and assign a pointer to it of a type that is longer than the
> allocated storage.  The initial buffer overrun was due to 
> problems with
> this.

IMO then, your original patch should be good.