[PATCH] Fix ide-mod unload crash

Herbert Xu (herbert@gondor.apana.org.au)
Tue, 3 Jun 2003 21:01:00 +1000


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-28749-1054715841-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

This patch fixes an unload crash when no PCI drivers are loaded.

It's scary that people writing code like this is hacking on the
driver where all my data is stored on! Time to make more backups :)

-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

--=_courier-28749-1054715841-0001-2 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=p

Index: drivers/ide/ide-proc.c =================================================================== RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/ide/ide-proc.c,v retrieving revision 1.1.1.6 diff -u -r1.1.1.6 ide-proc.c --- drivers/ide/ide-proc.c 1 Jun 2003 03:06:25 -0000 1.1.1.6 +++ drivers/ide/ide-proc.c 3 Jun 2003 10:54:58 -0000 @@ -982,16 +982,11 @@ void proc_ide_destroy(void) { #ifdef CONFIG_BLK_DEV_IDEPCI - ide_pci_host_proc_t *p = ide_pci_host_proc_list; - char name[32]; + ide_pci_host_proc_t *p; - while ((p->name != NULL) && (p->set) && (p->get_info != NULL)) { - name[0] = '\0'; - sprintf(name, "ide/%s", p->name); + for (p = ide_pci_host_proc_list; p; p = p->next) { if (p->set == 2) remove_proc_entry(p->name, p->parent); - if (p->next == NULL) break; - p = p->next; } #endif /* CONFIG_BLK_DEV_IDEPCI */ remove_proc_entry("ide/drivers", proc_ide_root);

--=_courier-28749-1054715841-0001-2--