Re: [patch] SiS IRQ router 96x detection ...

[Davide Libenzi]

On Tue, 3 Jun 2003, Alan Cox wrote:

> On Maw, 2003-06-03 at 07:06, Davide Libenzi wrote:
> > Thanks to Thomas we now know how to detect the 96x SiS SB. The patch
> > against 2.4.20 uses the documentated method to use the correct router
> > function and hence make new SiS chipsets to work with the new USB routing
> > registers. Tested and working fine on my machine.
>
> > +	{ "PIIX", PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371FB_0, pirq_piix_get, pirq_piix_set, NULL },
> > +	{ "PIIX", PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371SB_0, pirq_piix_get, pirq_piix_set, NULL },
>
> The NULL is implied so you don't need to mash every entry in the table..

I know is implied Alan, but you either use the std ".field = xxx" or you
fill out members. Otherwise the next one eventually extending the table
might find himself screwed. Or you use a macro to initialize each member.

- Davide