Re: [PATCH] radeonfb doesn't compile in 2.4.21-rc6

[Jocelyn Mayer]

Hello all,

Please apologize: 
I checked the code and I finaly noticed
that this is a linuxPPC bug and that the buggy lines haven't
been reported in the main kernel tree.
So I will resend the patch to the LinuxPPC mainteners instead.

I promise I will check better before complaining, 
the next time I'll do :=)

On Mon, 2003-06-02 at 22:24, James Mayer wrote:
> On Mon, Jun 02, 2003 at 08:24:56PM +0200, Jocelyn Mayer wrote:
> > It seems to me that this was already reported for previous
> > 2.4.21-rc's, but never applied.
> > Here's the patch that make radeonfb compile (and work)
> > on my Ibook:
> >

> maybe it was never applied because you don't cc the 2.4 maintainer (Marcelo  
> Tosati)?
> 
> ciao, Marc

Ooops, I didn't post this patch before, but I think someone did.
That's the point I wanted to show...

> >
> > 19:06:04.0000
> > 00000 +0200
> > +++ linux-2.4.21-rc6-fixed/drivers/video/radeonfb.c    2003-06-01
> > 20:58:42.0000
> > 00000 +0200
> > @@ -1001,8 +1001,8 @@
> >         /* According to XFree86 4.2.0, some production M6's return 0
> >            for 8MB. */
> >         if (rinfo->video_ram == 0 &&
> > -           (pdev->device == PCI_DEVICE_ID_RADEON_LY ||
> > -            pdev->device == PCI_DEVICE_ID_RADEON_LZ)) {
> > +           (pdev->device == PCI_DEVICE_ID_ATI_RADEON_LY ||
> > +            pdev->device == PCI_DEVICE_ID_ATI_RADEON_LZ)) {
> >             rinfo->video_ram = 8192 * 1024;
> >           }
> 
> Hi,
> 
> I can't seem to find PCI_DEVICE_ID_ATI_RADEON_LY or
> PCI_DEVICE_ID_ATI_RADEON_LZ defined *anywhere* in 2.4.21-rc6, and the
> 2.4.21-rc6 version of radeonfb.c compiled just fine for me.
> 
>  - James

-- 
Jocelyn Mayer <[e-mail]>