Re: [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations.

[Arnaldo Carvalho de Melo]

Em Mon, Jun 02, 2003 at 10:39:41AM -0600, Steven Cole escreveu:
> On Mon, 2003-06-02 at 09:59, Linus Torvalds wrote:
> > On 2 Jun 2003, Juan Quintela wrote:
> > > 
> > > /**
> > >  * foo - <put something there>
> > >  * @bar: number of frobnicators
> > >  * @baz: self-larting on or off
> > >  * @userdata: pointer to arbitrary userdata to be registered
> > >  *
> > >  * Description: Please, fix me
> > >  */
> > > int foo(long bar, long baz)
> > > {
> > > ...
> > > 
> > > Looks like a better alternative to me.
> > 
> > Hey, if somebody were to send me a patch (hint hint), I'd happily apply 
> > it.
> > 
> > 		Linus
> 
> I sent this last night as an example, except now the function
> declaration is not wrapped.  How is this?
> 
> Steven
> 
> --- linux/lib/zlib_inflate/inftrees.c.orig	Mon Jun  2 10:15:29 2003
> +++ linux/lib/zlib_inflate/inftrees.c	Mon Jun  2 10:16:47 2003
> @@ -288,14 +288,16 @@
>    return y != 0 && g != 1 ? Z_BUF_ERROR : Z_OK;
> +int zlib_inflate_trees_bits(uIntf *c, uIntf *bb, inflate_huft * FAR *tb, inflate_huft *hp, z_streamp z)
>  {
>    int r;
>    uInt hn = 0;          /* hufts used in space */

I do it like this:

int zlib_inflate_trees_bits(uIntf *c, uIntf *bb, inflate_huft * FAR *tb,
			    inflate_huft *hp, z_streamp z)

- Arnaldo