Re: Redundant code?

[Brian Gerst]

Stuart MacDonald wrote:
> Seems to me the following is redundant code, since get_fd_set also
> memsets the fds.res_* bitmaps.
> 
> ..Stu
> 
> --- linux-2.5.70/fs/select.c	2003-05-26 21:00:21.000000000 -0400
> +++ linux-2.5.70-new/fs/select.c	2003-06-02 11:40:24.000000000 -0400
> @@ -344,9 +344,6 @@
>  	    (ret = get_fd_set(n, outp, fds.out)) ||
>  	    (ret = get_fd_set(n, exp, fds.ex)))
>  		goto out;
> -	zero_fd_set(n, fds.res_in);
> -	zero_fd_set(n, fds.res_out);
> -	zero_fd_set(n, fds.res_ex);
>  
>  	ret = do_select(n, &fds, &timeout);
>  
> 

fds.in != fds.res_in

--
				Brian Gerst