Re: [PATCH][2.5] Honour dont_enable_local_apic flag

Brian J. Murrell (brian@interlinx.bc.ca)
02 Jun 2003 09:46:18 -0400


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-19647-1054561621-0001-2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2003-06-02 at 00:50, Zwane Mwaikambo wrote:
> I agree with doing the clear apic capability flag,

Indeed. I sure does seem to be the right way to go.

> Brian how does this=20
> fare? This patch alone should fix it.

It looks good and will try it out. But before I do, should not:

set_bit(X86_FEATURE_APIC, &disabled_x86_caps);

also be done?

>=20
> Index: linux-2.5/arch/i386/kernel/apic.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/cvs/linux-2.5/arch/i386/kernel/apic.c,v
> retrieving revision 1.54
> diff -u -p -B -r1.54 apic.c
> --- linux-2.5/arch/i386/kernel/apic.c 31 May 2003 19:01:05 -0000 1.54
> +++ linux-2.5/arch/i386/kernel/apic.c 2 Jun 2003 03:50:31 -0000
> @@ -609,7 +609,7 @@ static int __init detect_init_APIC (void
> =20
> /* Disabled by DMI scan or kernel option? */
> if (dont_enable_local_apic)
> - return -1;
> + goto no_apic;
> =20
> /* Workaround for us being called before identify_cpu(). */
> get_cpu_vendor(&boot_cpu_data);
> @@ -665,6 +665,7 @@ static int __init detect_init_APIC (void
> return 0;
> =20
> no_apic:
> + clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
> printk("No local APIC present or hardware disabled\n");
> return -1;
> }

b.

--=20
Brian J. Murrell <brian@interlinx.bc.ca>

--=_courier-19647-1054561621-0001-2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA+21Uql3EQlGLyuXARAr6dAKCXsXhhnjJ/JpCUpniOW0bSlNaiKwCfTUqR
8eloROxk2UM4smCc2futom0=
=+lTm
-----END PGP SIGNATURE-----

--=_courier-19647-1054561621-0001-2--