Re: [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b3).

[Anton Blanchard]

Hi,

> A new version of the 8.x series driver for Linux 2.5.x kernels has
> been uploaded to SourceForge:
> 
> 	http://sourceforge.net/projects/linux-qla2xxx/

A few suggestions:

- Use pci_set_mwi since it will set the cacheline size if necessary.
- Dont set/clear IO/MEMORY/MASTER, it should be handled in
  pci_enable_device/pci_set_master.

Anton

--- qla_init.c~	2003-05-31 09:18:31.000000000 +1000
+++ qla_init.c	2003-05-31 09:21:16.000000000 +1000
@@ -521,6 +521,7 @@
 	 * default.
 	 */
 	pci_set_master(ha->pdev);
+	pci_set_mwi(ha->pdev);
 	pci_read_config_word(ha->pdev, PCI_REVISION_ID, &ha->revision);
 
 	if (!ha->iobase)
@@ -532,18 +533,7 @@
 	 * interest to us are properly set in command register.
 	 */
 	pci_read_config_word(ha->pdev, PCI_COMMAND, &w);
-	w |= (PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER | 
-	    PCI_COMMAND_INVALIDATE | PCI_COMMAND_PARITY | PCI_COMMAND_SERR);
-
-#if MEMORY_MAPPED_IO
-	DEBUG(printk("scsi(%ld): I/O SPACE and MEMORY MAPPED I/O enabled.\n",
-	    ha->host_no));
-#else
-	DEBUG(printk("scsi(%ld): I/O SPACE enabled and MEMORY MAPPED I/O "
-	    "disabled.\n", ha->host_no));
-
-	w &= ~PCI_COMMAND_MEMORY;
-#endif
+	w |= (PCI_COMMAND_PARITY | PCI_COMMAND_SERR);
 
 #if defined(ISP2300)
 	/* PCI Specification Revision 2.3 changes */