Re: [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations.

[Linus Torvalds]

On Fri, 30 May 2003, Jörn Engel wrote:
> 
> How about an all or nothing approach?  If you really want to get rid
> of K&R, change indentation as well, rip out some of the rather
> tasteless macros (ZEXPORT, ZEXPORTVA, ZEXTERN, FAR, ...) and so on.

I'd love to, but I suspect we lack the motivation to do so, and there 
aren't any obvious upsides. Yes, the code is ugly, but it's also fairly 
stable so people seldom need to look at it.

The motivation for doing the ANSI-fication is just that there is now a 
sanity checker tool that will complain loudly about bad typing, and since 
I wrote it and I hate old-style K&R sources, it doesn't parse them. 

> You do have a point with the sync size.  The diff between 1.1.3 and
> 1.1.4 is 90k, of which only some 5k are functional changes.  The rest
> extends the copyright times, adds/changes documentation, etc.

I wouldn't mind syncing more, but one reason _against_ syncing the zlib 
sources have been the ugliness of them. Is there any reason for the 
K&R'ness any more, or the strange allocators?

		Linus