Re: [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations.

[Jörn Engel]

On Fri, 30 May 2003 13:48:12 -0700, Linus Torvalds wrote:
> 
> I personally consider K&R prototypes to be useless, and downright evil. 
> Any project who still has them is either lazy or still living in the 80's, 
> and in either case I don't see any reason not to clean up the kernel side.
> 
> Besides, I'm not aware of any reason to ever really sync with zlib on that
> level (the kinds of syncs I do foresee would be security issues or similar
> if some exploit is found, but that's unlikely to be a major sync).
> 
> We've historically done other surgery to the zlib sources to make them a
> bit more readable at times (the zlib allocator was just doing ridiculous
> things, the kernel version was changed to allocate small structures
> directly on the stack and embed others statically).

How about an all or nothing approach?  If you really want to get rid
of K&R, change indentation as well, rip out some of the rather
tasteless macros (ZEXPORT, ZEXPORTVA, ZEXTERN, FAR, ...) and so on.
The code is ugly, no doubt, but has the advantage of being close to
the upstream variant.  I would hate to have the combined problems of
ugly and forked code.

You do have a point with the sync size.  The diff between 1.1.3 and
1.1.4 is 90k, of which only some 5k are functional changes.  The rest
extends the copyright times, adds/changes documentation, etc.

Jörn

-- 
A defeated army first battles and then seeks victory.
-- Sun Tzu