Re: [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations.

[Jörn Engel]

On Fri, 30 May 2003 14:25:07 -0600, Steven Cole wrote:
> On Fri, 2003-05-30 at 14:14, Jörn Engel wrote:
> > On Fri, 30 May 2003 13:57:13 -0600, Steven Cole wrote:
> > > 
> > > Maybe the following should be unnecessary after all these years since
> > > the ANSI C standard was introduced, but several files associated with
> > > zlib were using the old-style function declaration.
> > 
> > In the case of the zlib, just leave it as it is.  The less changes we
> > make, to easier it is to merge upstream changes into the kernel.
> 
> Whoops, sorry.  Linus started the old-style to new-style conversion in
> zlib_inflate a few days ago, and I've sent Linus several patches
> finishing the job in zlib_deflate and elsewhere.  Some are already in
> the tree.

I would agree with that strategy, if the zlib wasn't actively
maintained anymore and we'd have to take over that part anyway.  But
as it is, this will create extra work with little bonus on our side,
except to set a better example maybe.

Linus, any insight to your reasons for this change?

Jörn

-- 
Rules of Optimization:
Rule 1: Don't do it.
Rule 2 (for experts only): Don't do it yet.
-- M.A. Jackson