Re: [PATCH] Graceful failure in devfs_remove() in 2.5.x

[Pavel Roskin]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-25385-1054137679-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On Wed, 28 May 2003, Christoph Hellwig wrote:

> On Tue, May 27, 2003 at 11:29:53AM -0400, Pavel Roskin wrote:
> > This patch makes devfs_remove() print an error to the kernel log and
> > continue.  PRINTK is defined in fs/devfs/base.c to report errors in the
> > cases like this one:
>
> Patch looks okay _except_ for use of this gross macro.  Just
> ise plain printk instead.

I always try to follow the existing code style, but if you want me to make
an exception, here it is.  Fixed patch is attached.

-- 
Regards,
Pavel Roskin
--=_courier-25385-1054137679-0001-2
Content-Type: text/plain; charset=us-ascii; name="devfs-rm.diff"
Content-Transfer-Encoding: base64
Content-ID: <[e-mail]>
Content-Description: 
Content-Disposition: attachment; filename="devfs-rm.diff"

LS0tIGxpbnV4Lm9yaWcvZnMvZGV2ZnMvYmFzZS5jDQorKysgbGludXgvZnMv
ZGV2ZnMvYmFzZS5jDQpAQCAtMTcxMCw2ICsxNzEwLDEyIEBAIHZvaWQgZGV2
ZnNfcmVtb3ZlKGNvbnN0IGNoYXIgKmZtdCwgLi4uKQ0KIAlpZiAobiA8IDY0
ICYmIGJ1ZlswXSkgew0KIAkJZGV2ZnNfaGFuZGxlX3QgZGUgPSBfZGV2ZnNf
ZmluZF9lbnRyeShOVUxMLCBidWYsIDApOw0KIA0KKwkJaWYgKCFkZSkgew0K
KwkJCXByaW50ayhLRVJOX0VSUiAiJXM6ICVzIG5vdCBmb3VuZCwgY2Fubm90
IHJlbW92ZVxuIiwNCisJCQkgICAgICAgX19GVU5DVElPTl9fLCBidWYpOw0K
KwkJCXJldHVybjsNCisJCX0NCisNCiAJCXdyaXRlX2xvY2soJmRlLT5wYXJl
bnQtPnUuZGlyLmxvY2spOw0KIAkJX2RldmZzX3VucmVnaXN0ZXIoZGUtPnBh
cmVudCwgZGUpOw0KIAkJZGV2ZnNfcHV0KGRlKTsNCg==

--=_courier-25385-1054137679-0001-2--