[2.5] [Cool stuff] "checking" mode for kernel builds

[Carl-Daniel Hailfinger]

Linus,

while eagerly waiting for the release of that tool, I have a few
comments about the patch itself.

> # The following is the BitKeeper ChangeSet Log
> # --------------------------------------------
> # 03/05/07	[e-mail]	1.1063.14.3
> # Support a "checking" mode for kernel builds, that runs a
> # user-supplied source checker on all C files before compiling
> # them.
> # 
> # I'll release the actual checker once I've cleaned it up a
> # bit more (yay, all the copyright paperwork completed!)
> # --------------------------------------------
> #
> [...]
> @@ -172,6 +182,7 @@
>  DEPMOD		= /sbin/depmod
>  KALLSYMS	= scripts/kallsyms
>  PERL		= perl
> +CHECK		= /home/torvalds/parser/check

Hardcoded path

>  MODFLAGS	= -DMODULE
>  CFLAGS_MODULE   = $(MODFLAGS)
>  AFLAGS_MODULE   = $(MODFLAGS)
> @@ -66,6 +66,12 @@
>  	 $(subdir-ym) $(always)
>  	@:
>  
> +# Linus's kernel sanity checking tool

IIRC my english lessons it should be
+# Linus' kernel sanity checking tool

> +ifneq ($(KBUILD_CHECKSRC),0)
> +quiet_cmd_checksrc = CHECK   $<
> +      cmd_checksrc = $(CHECK) $(CFLAGS) $< ;
> +endif
> + 
>  # Module versioning
>  # ------------------------------------------------------
>  

Regards,
Carl-Daniel