Re: [patch] futex requeueing feature, futex-requeue-2.5.69-D3

Ingo Molnar (mingo@elte.hu)
Tue, 20 May 2003 08:19:03 +0200 (CEST)


On Tue, 20 May 2003, Rusty Russell wrote:

> 1) Overload the last futex arg (change from timeval * to void *),
> don't add YA arg at the end.

the right approach is the splitup of the arguments, done in the later
cleanup patch. But i'd rather add yet another argument than some nasty
overload of arguments ...

> 2) Use __alignof__(u32) not sizeof(u32). Sure, they're the same, but
> you really mean __alignof__ here.

ok. Could they ever be realistically different?

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/