Re: [PATCH] Add boot command line parsing for the e100 driver

[Corey Minyard]

Bartlomiej Zolnierkiewicz wrote:

>On Tue, 20 May 2003, Bartlomiej Zolnierkiewicz wrote:
>  
>
>>On Mon, 19 May 2003, Corey Minyard wrote:
>>
>>    
>>
>>>Jeff Garzik wrote:
>>>
>>>      
>>>
>>>>>instead of adding such horrible cruft Corey did it should just use the
>>>>>proper API.
>>>>>
>>>>>
>>>>>          
>>>>>
>>>>An API already exists, and it is source compatible between 2.4 and 2.5:
>>>>ethX=.... on the kernel command line.
>>>>
>>>>The proper patch would pick up options from there.
>>>>
>>>>        
>>>>
>>>Can you tell me where this is?  I found the "ether=xxx" and
>>>"netdev=xxx", but they are not suitible.  I also could not find
>>>"module_parame" anywhere on google or in the kernel.
>>>
>>>-Corey
>>>      
>>>
>>:-) module_parm(), look at include/linux/moduleparam.h
>>and scsi for usage examples
>>    
>>
>
>ugh. s/module_parm/module_param/
>
Thank you.  Nobody seems to be able to type correctly today :-).  I had
actually found it, and looked it over.  It looks pretty nice, although
the lack of documentation is somewhat annoying.

However, if the ethX=.... exists, I would far prefer to use that.  (The
parameters for what  am doing have to be at bootup to work, it can't be
after the fact.  I hunted for a while, and I still couldn't find it,
btw.)  Otherwise, it's really up to the driver maintainers.  I will
adjust as they want, I will use the module_param stuff or the old
__setup stuff.  I would like to get this in, though.

-Corey