Re: [PATCH] remove 2.2 compat cruft from sound/

[Christoph Hellwig]

On Mon, May 19, 2003 at 11:38:56AM +0200, Christoph Hellwig wrote:
> On Mon, May 19, 2003 at 10:44:46AM +0200, Jaroslav Kysela wrote:
> > We still support the 2.2 kernel. We are trying to separate this 
> > "compatibility" code to another location, but in some cases, it is 
> > difficult. Please, make changes only for /sound/oss tree. Thank you.
> 
> I sterongly disagree.  As part of having your code in mainline you
> have to keep it readable.  Neither the compat mess nor the typedef
> abuse help on this.
> 

And it's not like the 2.2 code was actually working, e.g. the dropping
of i_sem in ->write makes you allow multiple simultanous writes, your
module refcounting on 2.2 is completly b0rked due to the lack of ->owner
and many functions have change parameters..