Re: [PATCH] Added missing dependencies on CRYPTO_HMAC

[Adrian Bunk]

On Sun, May 18, 2003 at 01:40:28PM +1000, James Morris wrote:
> On Sun, 18 May 2003, Herbert Xu wrote:
> 
> > On Sun, May 18, 2003 at 12:19:09PM +1000, James Morris wrote:
> > > 
> > > See crypto/Kconfig, CRYPTO_HMAC is being defaulted to Y if these protocols 
> > > are selected.
> > 
> > Yes, but the user can then set them to no.  This does happen as the
> > Crypto menu is listed after Networking so someone going through it
> > in that order can select INET_AH and then go on to disable Crypto.
> 
> Yes, we allow users to override the defaults if they wish, at their own 
> peril.
> 
> > Dependencies are there to prevent these things from happening.
> 
> Using dependencies would mean that the ipsec protocols would not appear in 
> the networking menu until after selecting the correct algorthims in the 
> crypto menu.
> 
> How would users know what the minimally required set of algorithms are?  
> Would they then know to go _back_ to the networking menu to enable the
> protocols?

It seems the cryptographic options don't depend on anything else. What 
about Herbert's patch plus moving the crypto menu above network support?

> - James

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed