Re: request_firmware() hotplug interface, third round.

[Manuel Estrada Sainz]

On Sat, May 17, 2003 at 07:07:05PM +1000, David Gibson wrote:
> On Sat, May 17, 2003 at 10:46:12AM +0200, Manuel Estrada Sainz wrote:
> > On Sat, May 17, 2003 at 02:44:59PM +1000, David Gibson wrote:
> > > On Fri, May 16, 2003 at 05:03:38PM -0700, Greg Kroah-Hartman wrote:
> > > > On Sat, May 17, 2003 at 01:55:15AM +0200, Oliver Neukum wrote:
> > > > > 
[snip]
> How about combining these two ideas: instead of "loading" and "data"
> we have "size" and "data".  First you write the size, then the data -
> the driver accepts it once it gets the expected number of bytes.
> Writing a new size throws away any partial image that's there, and
> restarts the upload.  Writing 0 cancels the upload entirely, and the
> driver will presumably fail to initialize (or maybe use a default
> image if it has one).

 Sounds good. I'll try that.
 
> There's another question - what happens if userspace tries to write an
> image when the driver hasn't requested one through hotplug?

 If you use request_firmware() directly, userspace will not find any
 file to write to :-)

 If you really want to be able to do that, instead of using
 request_firmware() you could register a class_device of class firmware
 and implement 'size'_show/store and 'data'_read/write. Thus exposing
 the firmware memory to userspace. The sequence would be like this:
	- On size_store you setup the download.
	- You can write directly to the device's memory on data_write.
	- Once you get all data you get the device back working.

 With this approach, you get the hotplug event for free and can take
 advantage of compatible userspace scripts.

 This is not currently possible, but should be easy to do if found
 interesting. I'll provide a (non-functional) sample next time.

 Thanks

 	Manuel

-- 
--- Manuel Estrada Sainz <[e-mail]>
                         <[e-mail]>
			 <[e-mail]>
------------------------ <[e-mail]> -------------------
Let us have the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.