Re: [PATCH][ATM] add reference counting to atm_dev

[chas williams]

In message <[e-mail]>,Greg KH writes:
>It's not really bothering me, just wondering when it will go away (I see
>it when building one of the USB ATM drivers...)

the MOD_* functions in the speedtch driver don't need to be there.  
since 2.3.something (if i remember correctly) the reference counting
has been handled by the upper layer (ala fops_get/fops_put).  the
following patch removes these extra bits:

--- linux-2.5.68/drivers/usb/misc/speedtch.c.000	Thu May 15 10:29:20 2003
+++ linux-2.5.68/drivers/usb/misc/speedtch.c	Thu May 15 10:29:32 2003
@@ -939,19 +939,15 @@
 		return -EAGAIN;
 	}
 
-	MOD_INC_USE_COUNT;
-
 	down (&instance->serialize); /* vs self, udsl_atm_close */
 
 	if (udsl_find_vcc (instance, vpi, vci)) {
 		up (&instance->serialize);
-		MOD_DEC_USE_COUNT;
 		return -EADDRINUSE;
 	}
 
 	if (!(new = kmalloc (sizeof (struct udsl_vcc_data), GFP_KERNEL))) {
 		up (&instance->serialize);
-		MOD_DEC_USE_COUNT;
 		return -ENOMEM;
 	}
 
@@ -1021,8 +1017,6 @@
 
 	up (&instance->serialize);
 
-	MOD_DEC_USE_COUNT;
-
 	dbg ("udsl_atm_close successful");
 }