Re: 2.5.69-mjb1: undefined reference to `blk_queue_empty'

[Bharata B Rao]

On Thu, May 15, 2003 at 09:29:37AM +0200, Jens Axboe wrote:
> > 
> > --- 2569+mjb1/drivers/dump/dump_blockdev.c.orig	Wed May 14 13:23:36 2003
> > +++ 2569+mjb1/drivers/dump/dump_blockdev.c	Thu May 15 09:26:12 2003
> > @@ -258,10 +258,19 @@
> >  dump_block_silence(struct dump_dev *dev)
> >  {
> >  	struct dump_blockdev *dump_bdev = DUMP_BDEV(dev);
> > +	struct request_queue *q = bdev_get_queue(dump_bdev->bdev);
> > +	int ret;
> > +
> > +	/* If we can't get request queue lock, refuse to take the dump */
> > +	if (!spin_trylock(q->queue_lock))
> > +		return -EBUSY;
> > +
> > +	ret = elv_queue_empty(q);
> > +	spin_unlock(q->queue_lock);
> >  
> >  	/* For now we assume we have the device to ourselves */
> >  	/* Just a quick sanity check */
> > -	if (!blk_queue_empty(bdev_get_queue(dump_bdev->bdev))) {
> > +	if (!ret) {
> >  		/* i/o in flight - safer to quit */
> >  		return -EBUSY;
> >  	}
> 
> Are interrupts already disabled at this point? If yes, then it looks
> fine.
> 

Yes, interrupts are disabled at this point.

Martin, Could you please take this in, while I push this change to lkcd cvs.

Regards,
Bharata.