Re: 2.5.69+bk: "sleeping function called from illegal context" on card release while shutting down

[Alex Riesen]

Alex Riesen, Tue, May 13, 2003 19:21:14 +0200:
> Paul Fulghum, Tue, May 13, 2003 17:31:01 +0200:
> > Individual PCMCIA drivers need to be updated to call
> > thier release function directly when processing a
> > CARD_RELEASE message instead of from a timer procedure.
> > 
> > Similar to this patch for synclink_cs.c:
> ...
> > -		    mod_timer(&link->release, jiffies + HZ/20);
> > +		    mgslpc_release((u_long)link);
> 
> Tried that. This time the trace looks different:
> 

I was probably too fast with the conclusions. It seemed I didn't update
modules (though I and bash history distinctly remember doing that).

I cannot reproduce the trace anymore. The patch was:

--- pcnet_cs.c	2003-04-30 06:17:05.000000000 +0200
+++ pcnet_cs.c	2003-05-13 19:31:12.000000000 +0200
@@ -848,7 +848,7 @@ static int pcnet_event(event_t event, in
 	link->state &= ~DEV_PRESENT;
 	if (link->state & DEV_CONFIG) {
 	    netif_device_detach(&info->dev);
-	    mod_timer(&link->release, jiffies + HZ/20);
+	    pcnet_release((u_long)link);
 	}
 	break;
     case CS_EVENT_CARD_INSERTION: