Re: ioctl32: kill code duplication (sparc64 tester wanted)

[Christoph Hellwig]

On Mon, May 12, 2003 at 03:13:26PM +0200, Pavel Machek wrote:
> > What's the reason you can't build fs/compat_ioctl.c normally and pull
> > in the arch magic through a magic asm/ header?  
> 
> Some architectures need special stuff (mtrr's), so I'd have to include
> .c files, too (the other way). [Look at how the table of ioctls is
> generated, its asm magic].

Shouldn't that special stuff move to the dynamic ioctl handler
registration method or the new ->compat_ioctl?

> Are you asking why are there #includes in compat_ioctl.c? Its because
> there is so many of them, and having to update all archs when you
> tuoch fs/compat_ioctl.c would be bad.

I'm asking for the #ifdef INCLUDES in fs/compat_ioctl.c.  Why do you
need it instead of including the headers uncondtionally?