Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!)

[Greg KH]

On Sat, May 10, 2003 at 09:52:49AM -0400, chas williams wrote:
> In message <[e-mail]>,Christoph Hellwig writes:
> >> +init_one_failure:
> >> +	if (atm_dev) atm_dev_deregister(atm_dev);
> >> +	if (he_dev) kfree(he_dev);
> >> +	pci_disable_device(pci_dev);
> >> +	return err;
> >
> >kfree(NULL) if perfectly fine.  Also please untangle all this if
> >statements to two separate lines.
> 
> but its ok for usb drivers?

Not at all.  I'll gladly take patches to fix this crud up.

thanks,

greg k-h