Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE

[David S. Miller]

   From: chas williams <[e-mail]>
   Date: Sat, 10 May 2003 09:52:49 -0400

   In message <[e-mail]>,Christoph Hellwig writes:
   >kfree(NULL) if perfectly fine.  Also please untangle all this if
   >statements to two separate lines.
   
   but its ok for usb drivers?
   
Bad ugly code in one area of the kernel is not an excuse
for it in other areas :-)

Really, putting a statement on the same line as the if
test controlling it's execution is very unreadable.  Most
people's eyes expect to see:

	if (test)
		IF_CODE_BLOCK

Whether it be one or more lines.  I cannot count how many locking bugs
escaped for a long time because of utter shit like this:

	if (test) return 0;