Re: [PATCH] remove unused funcion proc_mknod

[Jaroslav Kysela]

On Mon, 5 May 2003, Christoph Hellwig wrote:

> On Mon, May 05, 2003 at 08:22:48PM +0100, [e-mail] wrote:
> > manually.  IOW, removal of proc_mknod() won't solve anything.  The
> > real question is whether we should allow device nodes on procfs.
> > If we should not allow them, ALSA needs API changes.  If we should,
> > it'd be better to have creation of such nodes explicit (and if ALSA
> > keeps doing that, it should switch to calling proc_mknod()).
> 
> We shouldn't.  It's very bad style.  And it seems ALSA also registers a
> chardev and devfs entries for that stuff.
> 
> Jaroslav, can we just drop that junk or is it still used by userland.
> And if yes how long will it take to get an alsa-libs release out to
> not rely on it?

alsa-lib doesn't rely on it at all. The devices in /dev/snd/ might be 
created in these ways:

1) static - using the mknod command
2) using devfs
3) link /dev/snd to /proc/asound/dev

We prefered the third solution because we were changing heavily the device
minor numbers in the past. We can remove the proc dynamic device creating
from our code now. I agree, this code should not be in the kernel tree.

						Jaroslav

-----
Jaroslav Kysela <[e-mail]>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs