Re: Bogus Warning in ppp_generic.c

[Christoph Hellwig]

On Fri, May 09, 2003 at 10:24:01AM +0200, Norbert Wolff wrote:
>  	printk(KERN_INFO "PPP generic driver version " PPP_VERSION "\n");
>  	err = register_chrdev(PPP_MAJOR, "ppp", &ppp_device_fops);
> +
> +#ifdef CONFIG_DEVFS_FS
>  	if (!err) {
>  		err = devfs_mk_cdev(MKDEV(PPP_MAJOR, 0),
>  				S_IFCHR|S_IRUSR|S_IWUSR, "ppp");
>  	}
> +#endif
>  
>  	if (!err)
>  		printk(KERN_ERR "failed to register PPP device (%d)\n", err);

Wrong fix :)  the error check is just reveresed, devfs_mk_cdev also returns
0 if CONFIG_DEVFS_FS is set and it succeded.

Btw, almost any occurance of #ifdef CONFIG_DEVFS_FS is a bug.