Re: [PATCH] Fix .altinstructions linking failures

Jörn Engel (joern@wohnheim.fh-wedel.de)
Wed, 7 May 2003 11:23:29 +0200


On Tue, 6 May 2003 08:30:55 +0200, Andi Kleen wrote:
>
> Some configs didn't link anymore because they got references from
> .altinstructions to __exit functions. Fixing it at the linker level
> is not easily possible. This patch just discards .text.exit at runtime
> instead of link time to avoid this.
>
> Idea from Andrew Morton.
>
> It will also fix a related problem with .eh_frame in modern gcc (so far
> only observed on x86-64, but could happen on i386 too)

But it sure won't make any embedded people happy. This adds .text.exit
(and .data.exit?) to the kernel image, which is nothing but
unnecessary bloat. Nothing inside those sections is ever used, yet
their footprint does hurt on small systems.

I've been a bit sceptical of the whole .altinstructions idea,
self-modifying code opens a can of worms for anyone trying to do code
analysis (coverage, verification,...). But with this followup, I
personally pay money to get that stuff ripped out again.

Jörn

-- 
The cost of changing business rules is much more expensive for software
than for a secretaty.
-- unknown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/