RE: [Bluetooth] HCI USB driver update. Support for SCO over HCI U

[Perez-Gonzalez, Inaky]

> From: Greg KH [mailto:[e-mail]]
> 
> > If usb_init_urb() is already testing for !urb, why
> > test it again? No doubt the compiler will probably
> > catch it if inlining ... but I think the best is
> > for usb_init_urb() to assume that urb is not NULL.
> > Let the caller make that sure.
> 
> Because people other than usb_alloc_urb() can call usb_init_urb().
> Yeah, I can remove the check, then any invalid caller will oops on the

Just documenting it should do :]

> first line of usb_init_urb().  I don't mind, was just trying to program
> a bit more defensibly.  You know, make it a "hardened driver"  :)

Stab right in the heart :] I think we all agree we prefer "hardened
coders".

Iñaky Pérez-González -- Not speaking for Intel -- all opinions are my own
(and my fault)