RE: [Bluetooth] HCI USB driver update. Support for SCO over HCI U

[Perez-Gonzalez, Inaky]

> From: Greg KH [mailto:[e-mail]]
>
> +int usb_init_urb(struct urb *urb)
> +{
> +	if (!urb)
> +		return -EINVAL;
> ...
> ...
> ...
> @@ -38,13 +61,14 @@
>  		mem_flags);
>  	if (!urb) {
>  		err("alloc_urb: kmalloc failed");
> -		return NULL;
> +		goto exit;
> +	}
> +	if (usb_init_urb(urb)) {
> +		kfree(urb);
> +		urb = NULL;
>  	}

If usb_init_urb() is already testing for !urb, why
test it again? No doubt the compiler will probably
catch it if inlining ... but I think the best is
for usb_init_urb() to assume that urb is not NULL.
Let the caller make that sure.

Sorry if this is a dup ... I am catching up with
my mail ...

Iñaky Pérez-González -- Not speaking for Intel -- all opinions are my own
(and my fault)