Re: [PATCH] Fix .altinstructions linking failures

[Andi Kleen]

On Tue, May 06, 2003 at 09:56:14PM +0200, Andi Kleen wrote:
> The driver is buggy. The #ifdef MODULE needs to be removed and proc_cpia_destroy 
> be marked __exit instead, then things will be ok.

FWIW I compiled a "maxi kernel" now (with everything that compiles compiled in) 
and only cpia seems to have this bug. So with this patch things should be ok
again.

-Andi

Index: linux/drivers/media/video/cpia.c
===================================================================
RCS file: /home/cvs/linux-2.5/drivers/media/video/cpia.c,v
retrieving revision 1.25
diff -u -u -r1.25 cpia.c
--- linux/drivers/media/video/cpia.c	25 Apr 2003 05:41:01 -0000	1.25
+++ linux/drivers/media/video/cpia.c	6 May 2003 20:08:34 -0000
@@ -1409,12 +1409,10 @@
 		LOG("Unable to initialise /proc/cpia\n");
 }
 
-#ifdef MODULE
-static void proc_cpia_destroy(void)
+static void __exit proc_cpia_destroy(void)
 {
 	remove_proc_entry("cpia", 0);
 }
-#endif /*MODULE*/
 #endif /* CONFIG_PROC_FS */
 
 /* ----------------------- debug functions ---------------------- */