Re: [PATCH] fix x86_64 pte_user() and floppy.h for 2.5.69

[Andi Kleen]

On Tue, May 06, 2003 at 04:04:04PM +0200, [e-mail] wrote:
> Andi,
> 
> 2.5.69 failed to link on x86_64 due to a missing reference to pte_user().
> I simply stole the one that i386 added in .68 -> .69.
> There's also irqreturn_t warnings on floppy.h -- fixed also by syncing
> with i386' floppy.h.

At least the floppy.h thing is already fixed.

The pte_user fix is not needed. The correct fix is to change the 
#ifdef mm/memory.c checks for. It's broken for most/all
architecture which are not i386 including x86-64. 
They have FIXADDR_START, but don't need this check and it's even
wrong to have it.

It should be probably just #ifdef __i386__ instead of checking
such common symbols or better just be moved into arch/i386/mm/fault.c

-Andi