Re: [PATCH] kmalloc_percpu

David S. Miller (davem@redhat.com)
Mon, 05 May 2003 20:40:02 -0700 (PDT)


From: Rusty Russell <rusty@rustcorp.com.au>
Date: Tue, 06 May 2003 14:08:27 +1000

In message <1052187119.983.5.camel@rth.ninka.net> you write:
> I think the fixed size pool is perfectly reasonable.

Yes. It's a tradeoff. I think it's worth it at the moment (although
I'll add a limited printk to __alloc_percpu if it fails).

I think you should BUG() if a module calls kmalloc_percpu() outside
of mod->init(), this is actually implementable.

Andrew's example with some module doing kmalloc_percpu() inside
of fops->open() is just rediculious.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/