Re: [Announcement] "Exec Shield", new Linux security feature

[H. Peter Anvin]

Followup to:  <[e-mail]>
By author:    Richard Henderson <[e-mail]>
In newsgroup: linux.dev.kernel
>
> On Sun, May 04, 2003 at 10:25:26AM -0400, Chuck Ebbert wrote:
> > asmlinkage int sys_iopl(unsigned long unused)
> > {
> >         struct pt_regs * regs = (struct pt_regs *) &unused;       <== yuck!
> [...]
> >   Shouldnt it be like this?
> > 
> > asmlinkage int sys_iopl (struct pt_regs regs)
> 
> No, it should be like 
> 
>   int sys_iopl (struct pt_regs *regs)
> 
> and assembly language should push the proper address.
> 
> The struct-as-argument form allows the compiler to
> smash the entire structure as it sees fit.
> 

Hardly - it has to correspond to the ABI for the platform."

Presumably that's where the "asmlinkage" piece comes in.

	-hpa
-- 
<[e-mail]> at work, <[e-mail]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64