Re: [PATCH] i386 vsyscall DSO implementation

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- From what I've read here so far there were no objections.  The only
comments were to list the pages in /proc/*/maps and somehow make the DSO
available as a real file in the filesystem.

The first I think is reasonable.  But it is orthogonal to this patch.
It applies as well to the code currently in the kernel.  I'm pretty sure
we can arrange this to happen but it doesn't have to be in this patch.

As for the second, I do not think this is a good idea at all.  In theory
there could be more then one such DSO in use.  Without looking at the
actual process' address space it is not possible to determine which one
is used.  Roland also has IIRC a patch for ptrace() which allows it to
access the vsyscall page.  This is the method you'll have to apply.
Your remote debugger will in any case have to use ptrace(), so this is
no new requirement.

The fake kernel DSO will indeed be visible through the
_dl_iterate_phdr() function.  This means programs have easy access to it.

And a few more points on the DSO solution:

+ since the DSO is build just like an ordinary userlevel DSO there is
  no problem with writing the code which goes into it in C.  It is
  not necessary to do what is necessary for the current functions.

+ the DSO method allows to introduce new kernel interfaces which do
  not require new syscalls.  Well, somehow the kernel must be entered
  but how this happens is not visible to the user code.  This could
  mean using a syscall but the actual syscall number changes with
  every release.

+ the mechanism can easily be transferred to other architectures.  It
  could in theory mean using syscall numbers as the kernel interface
  can be abandoned.  Syscalls would be indentified by name at runtime
  (which is, I think, what most people think is the right solution).
  This has a slight runtime impact but it could be almost reduced to
  nil (maybe prelink is already capable of doing this).

Having said this, Linus, could you apply the patch if you have no
objections so that we can move on and add the remaining pieces?

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+qr652ijCOnn/RHQRAoZEAKCJ3D39tZubMFK+NBdoIHsixF3qhgCeMM/o
+IA3Hu+EMdNA+UYI4jlG6ys=
=ENqC
-----END PGP SIGNATURE-----