Re: [RFC/PATCH] IDE Power Management try 1

[Jens Axboe]

On Fri, Apr 25 2003, Bartlomiej Zolnierkiewicz wrote:
> 
> On 25 Apr 2003, Benjamin Herrenschmidt wrote:
> 
> > > If you add REQ_DRIVE_INTERNAL, and kill the other ones I mentioned, fine
> > > with me then.
> > >
> > > 	rq->flags & REQ_DRIVE_INTERNAL
> > > 		rq->cmd[0] == PM
> > > 			pm stuf
> > > 		rq->cmd[0] = taskfile
> > > 			taskfile
> > >
> > > etc. Make sense?
> >
> > As I just wrote, I'd rather go the whole way then and break up flags
> > (which is a very bad name btw) into req_type & req_subtype, though
> > that would mean a bit of driver fixing....
> >
> > Ben.
> 
> req_type & req_subtype makes sense,
> but it is future since driver work is needed

100% agree. It's way too late to change that now. Besides, there's still
plenty of space in there, especially if the IDE bits are collapsed into
one.

-- 
Jens Axboe