Re: Filesystem AIO read-write patches

[Benjamin LaHaise]

On Thu, Apr 24, 2003 at 10:22:22AM +0530, Suparna Bhattacharya wrote:
> The task->io_wait field reflects the wait context in which
> a task is executing its i/o operations. For synchronous i/o
> task->io_wait is NULL, and the wait context is local on
> stack; for threads doing io submits or retries on behalf 
> of async i/o callers, tsk->io_wait is the wait queue 
> function entry to be notified on completion of a condition 
> required for i/o to progress. 

This is seriously wrong.  Changing the behaviour of functions to depend on 
a hidden parameter is bound to lead to coding errors.  It is far better to 
make the parameter explicite rather than implicite.

		-ben