Re: [PATCH] aha1740 update

[Christoph Hellwig]

On Thu, Apr 24, 2003 at 02:03:32PM +0200, Marc Zyngier wrote:
>   * forms part of the process of creating an executable the information
> @@ -44,6 +47,11 @@
>  #include <asm/system.h>
>  #include <asm/io.h>
>  
> +#include <linux/init.h>
> +#include <linux/device.h>
> +#include <linux/eisa.h>
> +#include <linux/dma-mapping.h>

If there's a chance put this before the <asm/*.h> includes.

> +/* This should really fit in driver/scsi/scsi.h, along with
> + * scsi_to_{pci,sbus}_dma_dir.... */

Right.  Please submit a patch to James.

> +/* Eventually this will go into an include file, but this will be later */

No. (okay, you just moved it..)

> +static Scsi_Host_Template driver_template = AHA1740;

Please initialize the struct here instead of the macro obsfucation.
(again not yhour fault, but you're touching the driver so please
clean it up while at it).

> -#include "scsi_module.c"
> +static __init int aha1740_init (void)
> +{
> +    driver_template.module = THIS_MODULE;

Please do this at compile-time.

>  /* Okay, you made it all the way through.  As of this writing, 3/31/93, I'm
>  [e-mail] or [e-mail].  I'll try to help as time

This comment looks a _bit_ outdated to me, what about nuking it?

Well, and as you're touching the driver big time a cleanup to follow
Documentation/CondingStyle would be nice.