Re: [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (4/4)

Jens Axboe (axboe@suse.de)
Thu, 24 Apr 2003 09:56:18 +0200


On Wed, Apr 23 2003, Bartlomiej Zolnierkiewicz wrote:
>
> diff -uNr linux-2.5.67-ac2-dtf3/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
> --- linux-2.5.67-ac2-dtf3/drivers/ide/ide-taskfile.c Wed Apr 23 15:44:36 2003
> +++ linux/drivers/ide/ide-taskfile.c Wed Apr 23 16:22:12 2003
> @@ -1054,6 +1054,25 @@
>
> EXPORT_SYMBOL(ide_raw_taskfile);
>
> +/*
> + * Comments to ide_diag_taskfile() apply here as well.
> + */
> +static int ide_bio_taskfile (ide_drive_t *drive, ide_task_t *args,
> + request_queue_t *q, struct bio *bio)
> +{

any reason you are passing q seperately instead of using &drive->queue?

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/